Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy: 1.27.3 -> 1.27.5 #306009

Merged
merged 1 commit into from
Apr 22, 2024
Merged

envoy: 1.27.3 -> 1.27.5 #306009

merged 1 commit into from
Apr 22, 2024

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Apr 22, 2024 •
edited by katexochen
Loading

Description of changes

Contains security fixes for:

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen @malt3
envoy: 1.27.3 -> 1.27.5
6debc21 
Co-authored-by: Malte Poll <[email protected]>
Signed-off-by: Paul Meyer <[email protected]>
@katexochen katexochen added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 22, 2024
@malt3 malt3 requested a review from LeSuisse April 22, 2024 14:22
@ofborg ofborg bot requested a review from lukegb April 22, 2024 14:43
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 22, 2024
@msanft
Copy link
Contributor

msanft commented Apr 22, 2024

Result of nixpkgs-review pr 306009 run on x86_64-linux 1

2 packages built:
  • envoy
  • pomerium

@adamcstephens
Copy link
Contributor

The deps bundle doesn't appear to be reproducible

┃ error: hash mismatch in fixed-output derivation '/nix/store/pvi8ylsgjb0m95fzbj4qhr9ywlbmx3gg-envoy-…
┃          specified: sha256-4XJgPfNEPmbvAZMLlQcnIaoGzaFtyhsuEshdEjLh0OY=
┃             got:    sha256-K+XjoX4GXRpdHzJKhfgVL7nbihfc14HAI7H2irm224k=

@malt3
Copy link
Contributor Author

malt3 commented Apr 22, 2024 •
edited
Loading

The deps bundle doesn't appear to be reproducible

┃ error: hash mismatch in fixed-output derivation '/nix/store/pvi8ylsgjb0m95fzbj4qhr9ywlbmx3gg-envoy-…
┃          specified: sha256-4XJgPfNEPmbvAZMLlQcnIaoGzaFtyhsuEshdEjLh0OY=
┃             got:    sha256-K+XjoX4GXRpdHzJKhfgVL7nbihfc14HAI7H2irm224k=

Can you upload your bundle somewhere, so I can diff it?

Looking at the backported #303227, it appears that the hashes provided here are the same.
Maybe there is only a small number of possible results, or the one we picked here is very likely.

@katexochen katexochen mentioned this pull request Apr 22, 2024
Merged
13 tasks
adamcstephens
adamcstephens approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@adamcstephens adamcstephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-ran this a couple times and couldn't recreate the hash mismatch.

@adamcstephens adamcstephens merged commit d940860 into NixOS:master Apr 22, 2024
32 of 33 checks passed
@malt3 malt3 deleted the envoy/1-27-5 branch April 22, 2024 17:06
@katexochen katexochen mentioned this pull request Apr 23, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamcstephens adamcstephens adamcstephens approved these changes

@LeSuisse LeSuisse Awaiting requested review from LeSuisse

@lukegb lukegb Awaiting requested review from lukegb

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malt3 @msanft @adamcstephens @katexochen